Generalize batched_vec to support N-D batches #652

Copilot · 2025-11-19T08:29:33Z

batched_vec was limited to 3D arrays. Now supports arbitrary dimensions when ndims(A) == ndims(B) + 1 and batch dimensions match size(A)[3:end] == size(B)[2:end], mirroring batched_mul behavior.

Changes

Implementation: Added general batched_vec(A::AbstractArray, B::AbstractArray) method
- Validates dimension requirements with clear error messages
- Uses batched_mul with reshape/dropdims pattern: dropdims(batched_mul(A, reshape(B, size(B,1), 1, size(B)[2:end]...)), dims=2)
- Existing 3D-specific methods preserved for backward compatibility
Tests: Added test suite covering 4D and 5D cases, dimension validation, type compatibility, and backward compatibility

Usage

# 4D case
A = randn(16, 8, 10, 32)  # (rows, cols, batch1, batch2)
B = randn(8, 10, 32)      # (vec_len, batch1, batch2)
C = batched_vec(A, B)     # → (16, 10, 32)

# 5D case  
A5 = randn(3, 4, 2, 3, 2)
B4 = randn(4, 2, 3, 2)
C5 = batched_vec(A5, B4)  # → (3, 2, 3, 2)

# 3D still works
A3 = randn(16, 8, 32)
B2 = randn(8, 32)
C3 = batched_vec(A3, B2)  # → (16, 32)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

127.255.255.255
https://api.github.com/repos/ElOceanografo/SparseInverseSubset.jl/tarball/52962839426b75b3021296f7df242e40ecfc0852
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/EnzymeAD/Enzyme.jl/tarball/37b98ffec3243cacd76806f06fd1832c1b9f728d
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/EnzymeAD/Enzyme.jl/tarball/820f06722a87d9544f42679182eb0850690f9b45
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/EnzymeAD/Enzyme.jl/tarball/fe9392aca36b7a7df131d49cd1a771117183a6c4
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/FluxML/IRTools.jl/tarball/57e9ce6cf68d0abf5cb6b3b4abf9bedf05c939c0
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/FluxML/MacroTools.jl/tarball/1e0228a030642014fe5cfe68c2c0a818f9e3f522
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/FluxML/Zygote.jl/tarball/a29cbf3968d36022198bcc6f23fdfd70f7caf737
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/FluxML/ZygoteRules.jl/tarball/434b3de333c75fc446aa0d19fc394edafd07ab08
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/GunnarFarneback/RegistryInstances.jl/tarball/ffd19052caf598b8653b99404058fce14828be51
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/FillArrays.jl/tarball/5bfcd42851cf2f1b303f51525a54dc5e98d408a3
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/MappedArrays.jl/tarball/2dab0221fe2b0f2cb6754eaa743cc266339f527e
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/MosaicViews.jl/tarball/7b86a5d4d70a9f5cdf2dacb3cbe6d251d1a61dbe
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/OffsetArrays.jl/tarball/117432e406b5c023f665fa73dc26e79ec3630151
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/PaddedViews.jl/tarball/0fac6313486baae819364c52b4f483450a9d793f
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/StackViews.jl/tarball/be1cf4eb0ac528d96f5115b4ed80c26a8d8ae621
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tarball/b8693004b385c842357406e3af647701fe783f98
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/StaticArraysCore.jl/tarball/6ab403037779dae8c514bad259f32a447262455a
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaArrays/StructArrays.jl/tarball/a2c37d815bf00575332b7bd0389f771cb7987214
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/Enzyme_jll.jl/tarball/46e6fa04c9bf0c8d5744b1ebb71e77dca0bd940a
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/Expat_jll.jl/tarball/27af30de8b5445644e8ffe3bcb0d72049c089cf1
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/FFTW_jll.jl/tarball/6d6219a004b8cf1e0b4dbe27a2860b8e04eba0be
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/Git_LFS_jll.jl/tarball/bb8471f313ed941f299aa53d32a94ab3bee08844
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/Git_jll.jl/tarball/b6a684587ebe896d9f68ae777f648205940f0f70
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/IntelOpenMP_jll.jl/tarball/ec1debd61c300961f98064cfb21287613ad7f303
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/LLVMExtra_jll.jl/tarball/8e76807afb59ebb833e9b131ebf1a8c006510f33
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/LibTracyClient_jll.jl/tarball/d2bc4e1034b2d43076b50f0e34ea094c2cb0a717
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/Libiconv_jll.jl/tarball/be484f5c92fad0bd8acfef35fe017900b0b73809
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/MKL_jll.jl/tarball/282cadc186e7b2ae0eeadbd7a4dffed4196ae2aa
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/OpenSSH_jll.jl/tarball/301412a644646fdc0ad67d0a87487466b491e53d
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/OpenSpecFun_jll.jl/tarball/1346c9208249809840c91b26703912dff463d335
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaBinaryWrappers/oneTBB_jll.jl/tarball/1350188a69a6e46f799d3945beef36435ed7262f
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaCollections/AbstractTrees.jl/tarball/2d9c9a55f9c93e8887ad391fbae72f8ef55e1177
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaCollections/DataStructures.jl/tarball/e357641bb3e0638d353c4b29ea0e40ea644066a6
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaCollections/OrderedCollections.jl/tarball/05868e21324cede2207c6f0f466b4bfef6d5e7ee
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaCollections/SortingAlgorithms.jl/tarball/64d974c2e6fdf07f8155b5b2ca2ffa9069b608d9
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaConcurrent/Atomix.jl/tarball/29bb0eb6f578a587a49da16564705968667f5fa8
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaConcurrent/UnsafeAtomics.jl/tarball/b13c4edda90890e5b04ba24e20a310fbe6f249ff
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaData/DataAPI.jl/tarball/abe83f3a2f1b857aac70ef8b269080af17764bbe
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaData/Missings.jl/tarball/ec4f7fbeab05d7747bdf98eb74d130a2a2ed298d
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaData/Parsers.jl/tarball/7d2f8f21da5db6a806faf7b9b292296da42b2810
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaData/Tables.jl/tarball/f2c1efbc8f3a609aadf318094f8fc5204bdaf344
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/ChainRules.jl/tarball/3b704353e517a957323bd3ac70fa7b669b5f48d4
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/ChainRulesCore.jl/tarball/e4c6a16e77171a5f5e25e9646617ab1c276c5607
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/ChainRulesTestUtils.jl/tarball/3619a1db187f17c8a220a3ed2231942a7b4a3ec2
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/DiffResults.jl/tarball/782dd5f4561f5d267313f23853baaaa4c52ea621
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/DiffRules.jl/tarball/23163d55f885173722d1e4cf0f6110cdbaf7e272
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/FiniteDifferences.jl/tarball/0ff4ed4351e1884beff16fc4d54490c6d56b2199
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/tarball/cd33c7538e68650bd0ddbb3f5bd50a4a0fa95b50
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDiff/ReverseDiff.jl/tarball/3ab8eee3620451b09f0272c271875b4bc02146d9
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDocs/ANSIColoredPrinters.jl/tarball/574baf8110975760d391c710b6341da1afa48d8c
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDocs/DocStringExtensions.jl/tarball/7442a5dfe1ebb773c29cc2962a8980f47221d76c
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDocs/Documenter.jl/tarball/70c521ca3a23c576e12655d15963977c9766c26b
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDocs/IOCapture.jl/tarball/0ee181ec08df7d7c911901ea38baf16f755114dc
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaDocs/MarkdownAST.jl/tarball/465a70f0fc7d443a00dcdc3267a497397b8a3899
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGPU/Adapt.jl/tarball/7e35fca2bdfba44d797c53dfe63a51fabf39bfc0
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGPU/GPUArrays.jl/tarball/83cf05ab16a73219e5f6bd1bdfa9848fa24ac627
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGPU/GPUCompiler.jl/tarball/90554fe518adab1b4c8f7a04d26c414482a240ca
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGPU/KernelAbstractions.jl/tarball/b5a371fcd1d989d844a4354127365611ae1e305f
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGeometry/Contour.jl/tarball/439e35b0b36e2e5881738abc8857bd92ad6ff9a8
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGeometry/CoordinateTransformations.jl/tarball/a692f5e257d332de1e554e4566a4e5a8a72de2b2
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGeometry/MarchingCubes.jl/tarball/0e893025924b6becbae4109f8020ac0e12674b01
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGeometry/Quaternions.jl/tarball/4d8c1b7c3329c1885b857abb50d08fa3f4d9e3c8
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGeometry/Rotations.jl/tarball/5680a9276685d392c87407df00d57c9924d9f11e
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGraphics/ColorSchemes.jl/tarball/b0fd3f56fa442f81e0a47815c92245acfaaa4e34
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGraphics/ColorTypes.jl/tarball/67e11ee83a43eb71ddc950302c53bf33f0690dfe
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGraphics/ColorVectorSpace.jl/tarball/8b3b6f87ce8f65a2b4f857528fd8d70086cd72b1
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaGraphics/Colors.jl/tarball/37ea44092930b1811e666c3bc38065d7d87fcc74
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/CodecZlib.jl/tarball/962834c22b66e32aa10f7611c08c8ca4e20749a9
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/JSON.jl/tarball/5b6bb73f555bc753a6153deec3717b8904f5551c
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/ObjectFile.jl/tarball/22faba70c22d2f03e60fbc61da99c4ebfc3eb9ba
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/StructIO.jl/tarball/c581be48ae1cbf83e899b14c07a807e1787512cc
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/Suppressor.jl/tarball/6dbb5b635c5437c68c28c2ac9e39b87138f37c0a
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaIO/TranscodingStreams.jl/tarball/0c45878dcfdcfa8480052b6ab162cdd138781742
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaImages/ImageBase.jl/tarball/eb49b82c172811fd2c86759fa0553a2221feb909
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaImages/ImageCore.jl/tarball/8c193230235bbcee22c8066b0374f63b5683c2d3
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaImages/ImageTransformations.jl/tarball/dfde81fafbe5d6516fb864dc79362c5c6b973c82
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaInterop/CEnum.jl/tarball/389ad5c84de1ae7cf0e28e381131c98ea87d54fc
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLLVM/LLVM.jl/tarball/ce8614210409eaa54ed5968f4b50aa96da7ae543
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLang/Compat.jl/tarball/9d8a54ce4b17aa5bdce0ea5c34bc5e7c340d16ad
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLang/FunctionWrappers.jl/tarball/d62485945ce5ae9c0c48f124a84998d755bae00e
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLang/ScopedValues.jl/tarball/c3b2323466378a2ba15bea4b2f73b081e022f473
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaLinearAlgebra/WoodburyMatrices.jl/tarball/c1a7aa6219628fcd757dede0ca95e245c5cd9511
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/AbstractFFTs.jl/tarball/d92ad398961a3ed262d8bf04a1a2b8340f915fef
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/FFTW.jl/tarball/97f08406df914023af55ade2f843c39e99c5d969
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/FixedPointNumbers.jl/tarball/05882d6995ae5c12bb5f36dd2ed3f61c98cbb172
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/Interpolations.jl/tarball/65d505fa4c0d7072990d659ef3fc086eb6da8208
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/IrrationalConstants.jl/tarball/b2d91fe939cae05960e760110b328288867b5758
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/NaNMath.jl/tarball/9b8215b1ee9e78a293f99797cd31375471b2bcae
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/RealDot.jl/tarball/9f0a1b71baaf7650f4fa8a1d168c7fb6ee41f0c9
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/Richardson.jl/tarball/48f038bfd83344065434089c2a79417f38715c41
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/SpecialFunctions.jl/tarball/f2685b435df2613e25fc10ad8c26dddb8640f547
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaMath/TensorCore.jl/tarball/1feb45f88d133a655e001435632f019a9a1bcdb6
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaObjects/ConstructionBase.jl/tarball/b4b092499347b18a015186eae3042f72267106cb
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaPackaging/JLLWrappers.jl/tarball/0533e564aae234aff59ab625543145446d8b6ec2
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/0f27480397253da18fe2c12a4ba4eb9eb208bf3d
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaPackaging/Requires.jl/tarball/62389eeff14780bfe55195b7204c0d8738436d64
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaPackaging/Scratch.jl/tarball/9b81b8393e50b7d4e6d0a9f14e192294d3b7c109
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaPlots/UnicodePlots.jl/tarball/0087c82cf98f2c2bb7df350c02b0b1fc6ae087d6
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaRandom/StableRNGs.jl/tarball/4f96c596b8c8258cc7d3b19797854d368f243ddc
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaServices/StructUtils.jl/tarball/79529b493a44927dd5b13dde1c7ce957c2d049e4
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaStats/LogExpFunctions.jl/tarball/13ca9e2586b89836fd20cccf56e57e2b9ae7f38f
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaStats/Statistics.jl/tarball/ae3bb1eb3bba077cd276bc5cfc337cc65c3075c0
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaStats/StatsAPI.jl/tarball/9d72a13a3f4dd3795a195ac5a44d7d6ff5f552ff
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaStats/StatsBase.jl/tarball/064b532283c97daae49e544bb9cb413c26511f8c
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaTesting/ExprTools.jl/tarball/27415f162e6028e81c72b82ef756bf321213b6ec
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/JuliaVersionControl/Git.jl/tarball/824a1890086880696fc908fe12a17bcf61738bd8
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/KristofferC/Crayons.jl/tarball/249fe38abf76d48563e2f4556bebd215aa317e15
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/KristofferC/LazilyInitializedFields.jl/tarball/0f2da712350b020bc3957f269c9caad516383ee0
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/LilithHafner/AliasTables.jl/tarball/9876e1e164b144ca45e9e3198d0b689cadfed9ff
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/LilithHafner/PtrArrays.jl/tarball/1d36ef11a9aaf1e8b74dacc6a731dd1de8fd493d
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/queryverse/DataValueInterfaces.jl/tarball/bfc1187b79289637fa0ef6d4436ebdfe6905cbd6
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/queryverse/IteratorInterfaceExtensions.jl/tarball/a3f24677c21f5bbe9d2a714f95dcd58337fb2856
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/queryverse/TableTraits.jl/tarball/c06b2f539df1c6efa794486abfb6ed2022561a39
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/rdeits/CommonSubexpressions.jl/tarball/cda2cfaebb4be89c9084adaca7dd7333369715c5
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/simonster/Reexport.jl/tarball/45e428421666073eab6f2da5c9d310d99bb12f9b
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/timholy/AxisAlgorithms.jl/tarball/01b8ccb13d68535d73d2b0c23e39bd23155fb712
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/timholy/Ratios.jl/tarball/1342a47bf3260ee108163042310d26f2be5ec90b
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/topolarity/Tracy.jl/tarball/73e3ff50fd3990874c59fef0f35d10644a1487bc
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
https://api.github.com/repos/vchuravy/HashArrayMappedTries.jl/tarball/2eaa69a7cab70a52b9687c8bf950a5a93ec895ae
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (http block)
pkg.julialang.org
- Triggering command: julia --project=. -e using Pkg; Pkg.test("NNlib"; test_args=["batchedmul"]) (dns block)
- Triggering command: /usr/local/julia1.12.1/bin/julia -C native -J/usr/local/julia1.12.1/lib/julia/sys.so -g1 --code-coverage=none --color=yes --check-bounds=yes --warn-overwrite=yes --depwarn=yes --inline=yes --startup-file=no --track-allocation=none --check-bounds=yes --output-o /home/REDACTED/.julia/compiled/v1.12/MKL_jll/jl_dr4kUk --output-ji /home/REDACTED/.julia/compiled/v1.12/MKL_jll/jl_SLguzl --output-incremental=yes --startup-file=no --history-file=no --warn-overwrite=yes --color=yes - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>batched_vec for N-D batches</issue_title>
<issue_description>### Motivation and description

Feature Request: Generalized batched_vec for N-D batches

batched_vec currently only supports the 3D case but not the natural N-D generalization. Please add support when ndims(A) == ndims(B) + 1 and the batch dims match size(A)[3:end] == size(B)[2:end], mirroring batched_mul’s behavior.

Possible Implementation
function batched_vec(A::AbstractArray{T}, B::AbstractArray{T}) where T
    @assert ndims(A) == ndims(B) + 1 && size(A)[3:end] == size(B)[2:end]
    return dropdims(batched_mul(A, reshape(B, size(B,1), 1, size(B)[2:end]...)), dims=2)
end
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@CarloLucibello</author><body>
seems reasonable, PR welcome.</body></comment_new>
</comments>

Fixes batched_vec for N-D batches #645

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: CarloLucibello <[email protected]>

src/batched/batchedmul.jl

CarloLucibello · 2025-11-19T09:12:18Z

test/batchedmul.jl

+    # Test that 3D case still works (backward compatibility)
+    A3d_test = randn(4, 5, 3)
+    B2d_test = randn(5, 3)
+    C3_test = batched_vec(A3d_test, B2d_test)
+    @test size(C3_test) == (4, 3)
+    for k in 1:3
+        @test C3_test[:, k] ≈ A3d_test[:, :, k] * B2d_test[:, k]
+    end


these are not needed

test/batchedmul.jl

Initial plan

8f33b7e

Copilot AI assigned Copilot and CarloLucibello Nov 19, 2025

Copilot started work on behalf of CarloLucibello November 19, 2025 08:31 View session

Implement generalized batched_vec for N-D batches

1fb01af

Co-authored-by: CarloLucibello <[email protected]>

Copilot AI changed the title ~~[WIP] Add support for generalized batched_vec for N-D batches~~ Generalize batched_vec to support N-D batches Nov 19, 2025

Copilot AI requested a review from CarloLucibello November 19, 2025 08:54

Copilot finished work on behalf of CarloLucibello November 19, 2025 08:54

CarloLucibello requested changes Nov 19, 2025

View reviewed changes

CarloLucibello marked this pull request as ready for review November 19, 2025 09:12

Update src/batched/batchedmul.jl

4cc6de3

CarloLucibello reviewed Nov 19, 2025

View reviewed changes

test/batchedmul.jl Outdated Show resolved Hide resolved

Update test/batchedmul.jl

69f61e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Generalize batched_vec to support N-D batches #652

Generalize batched_vec to support N-D batches #652

Uh oh!

Copilot AI commented Nov 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

CarloLucibello Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Generalize batched_vec to support N-D batches #652

Are you sure you want to change the base?

Generalize batched_vec to support N-D batches #652

Uh oh!

Conversation

Copilot AI commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

I tried to connect to the following addresses, but was blocked by firewall rules:

Feature Request: Generalized batched_vec for N-D batches

Possible Implementation

Uh oh!

Uh oh!

CarloLucibello Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Nov 19, 2025 •

edited

Loading

Feature Request: Generalized `batched_vec` for N-D batches